Top
Best
New

Posted by robbie-c 1 day ago

I rewrote PostHog's SQL parser, 70x faster, while barely looking at the code(posthog.com)
141 points | 70 commentspage 3
akitowerns 20 hours ago|
[dead]
jungfty 1 day ago||
[dead]
speedgoose 1 day ago||
[flagged]
sscaryterry 1 day ago||
This is true and unkind at the same time.
CodesInChaos 1 day ago||
1. Many cookie banners are required to satisfy the ePrivacy Directive, not just GDPR.

2. Since this is a tracking cookie, not a cookie required for the website to function, it requires consent. So I believe the banner is non compliant.

elmean 1 day ago||
[flagged]
pluc 1 day ago||
[dead]
CrzyLngPwd 1 day ago||
"I didn't rewrite"
sscaryterry 1 day ago|
Good read, but "70x" is always misleading.
robbie-c 1 day ago|
In what way? This was a geometric mean of the improvements from a small test corpus. In production, where it only parses longer SQL that didn't hit the parser cache, the mean parse time went down by 454x, across millions of parses.
hyperpape 1 day ago||
Sounds like the real number is 454x faster, not 70x. Checkmate, nerd!
sscaryterry 1 day ago|||
Go read my message again. Every time somebody states it is X time faster, and its the headline, it is pure clickbait.

Yes, you have benchmarks, they will always be synthetic. I'm not dismissing the work, just the selling of it.

You have succeeded though, I did click on it. I even said "Good read" :)

robbie-c 1 day ago|||
:D

I was hoping to avoid the criticism that I was picking the most favourable number and being misleading!