Top
Best
New

Posted by tomzorz 5 hours ago

Stacked PRs are now live on GitHub(github.blog)
254 points | 96 commentspage 2
jasonephraim 1 hour ago|
I was wondering why there was a pancake icon in my GitHub menu https://github.com/orgs/community/discussions/203497
qihqi 55 minutes ago||
inspired by https://github.com/ezyang/ghstack?
yreg 1 hour ago||
This page is unreadable for me (on iOS). The videos keep autoplaying and making themselves full screen.
johsole 3 hours ago||
Stacked PRs have been great, a huge boon for me. I was using it before the UI support, just on the command line. `gh stack rebase` is too useful.
rrradical 3 hours ago||
I thought 'stacking' PRs was useful in two circumstances.

1. The PRs are across different related repos, so they literally can't be combined into one PR.

2. You want to keep producing work while the first PR is in review. So you stack subsequent PRs onto the same branch. Basically just pipelining.

But this feature doesn't seem to hit either use case, and instead just seems to be a different form of stacking commits into a single PR. The standard advice has always been to make atomic and meaningful commits (using e.g. rebase to tell a nice story for the reviewer). And reviewers can go through commit by commit if they like.

What am I missing?

paxys 1 hour ago||
This is a huge feature if implemented well. Going from big organizations with their own custom-built versions of PR stacking back to vanilla GitHub was a huge productivity hit for me.
jeremy_k 3 hours ago||
Been using it over the last week. Only complaint I had was that `gh stack rebase` was struggling rebasing after squash merges but I got a response that the rebasing had been improved so I'm looking forward to trying that out.
8260337551 3 hours ago||
Rejoice, finally a new feature that isn't AI related.
smoll 3 hours ago||
Not AI related, but I plan on having my agents use this heavily so I can review PRs in bite-sized chunks instead of all at once.
techscruggs 3 hours ago||
I get your point, but it kind of is AI related. The size of PRs since AI has made it much harder to review a diff. Stacking the PRs seems like a response to this problem.
amethyst 2 hours ago|||
We were benefiting from stacked pull requests in Phabricator for a decade before "AI" was a thing. Having well scoped commits that can be individually actioned by distinct sets of reviewers has always been extremely useful.
IshKebab 58 minutes ago|||
It definitely isn't. People have wanted this for many years. It's an obvious workflow. There's been a feature request since at least 2020 and I'm sure there were earlier ones: https://github.com/cli/cli/issues/2693
santoriv 1 hour ago||
The important question in the age of PR metrics as a yardstick for keeping your job:

When you click merge, does a 3 stack PR show up as 1 PR in the Dx metrics or 3?

zxspectrum1982 1 hour ago|
I don't like this.

The case where I need stacked PRs is when I have a ton of changes and I want to upstream them. I have so many changes that I have probably written code in this order: 1. feature1 work 2. feature2 work 3. architecture rework 4. docs 5. feature3 work 6. optimization 7. docs 8. feature4 work 9. security fixes 10. optimization 11. docs 12. last pass security fixes

By the time I want to upstream, I probably want to reorder my commits and generate on PR per theme (arch, feature1 + docs + optimization, feature2+docs + optimization, etc) before I submit a bunch of PRs.

GitHub stacked PRs solve none of my problems. Stacked PRs doesn't take care of the reordering of commits, it doesn't take care of rebasing changes, it adds very little on top of what I was already able to do by saying "this is PR 1 out of 7, this is PR2 out of 7 and build on top of the branch that I used for PR1/7, etc".

Hugely disappointing, bordering useless.

IshKebab 1 hour ago|
> it adds very little on top of what I was already able to do by saying "this is PR 1 out of 7, this is PR2 out of 7 and build on top of the branch that I used for PR1/7, etc".

That's literally all it's supposed to do. Make that dev flow less awful so you don't have to say "by the way this PR depends on #123, I will change the target branch when that is merged" and nonsense like that.

More comments...