Top
Best
New

Posted by xiaoyu2006 17 hours ago

GitHub New pull request overview page in public preview(github.blog)
166 points | 113 commentspage 2
sickcodebruh 15 hours ago|
Been using Graphite all year. I had trouble adapting my GitHub mind to it at first and I still don’t love everything about Graphite, but _wow_ is Graphite’s PR review page organized better than GitHub. GitHub’s new PR stack is superior (atomic merges are life-changing) and having one fewer tokens to manage CLI to install is fantastic, but I’m still mostly Graphite because the page is just organized better.

Specifically, graphite wins on:

- I land on the page and immediately see an overview of my whole PR stack: what’s in the stack, what’s passing, what’s failing, what’s draft, unresolved and total comments. I know exactly where to spend my time. GitHub PR stacks offer no such convenience.

- Description is below stack details, then code, and I never have to switch tabs or pages. This hierarchy makes sense: top of the page is broad whole stack details, and as we go down we get more specific. GitHub forces me to jump between pages to see all of this.

- Comments in a drawer are nice. Being able to quickly scan them helps me get a sense of what’s there, who’s commenting, I can jump between them quickly.

- Approval, request, labels, etc are also logically oriented at the top near other metadata. GitHub sprawls this around the page. It’s especially rough on mobile browser.

I just checked the new overview. It’s a step up. Curious to see if it helps the PR stack experience. I’d love to fully migrate off Graphite, the non-atomic merge is truly a nightmare across a large stack, but at the end of the day I haven’t been able to give up the UX gains of managing my work on Graphite compared to GitHub.

pushcx 15 hours ago||
I tried it this morning, I guess it's for business rather than open source? The first PR I opened was slop that violated the project's policies. The new UI is missing both report and block.

There's not really any improvement to the core problem with PRs. You still have to read up and down the entire comments tab and then again the entire diff tab (hunting and clicking each "load more" and re-opening every "resolved" thread to find invisible replies) to reconstruct the timeline of what's happened in your head because nothing's in temporal order and there's still no interdiff.

lacoolj 11 hours ago||
Hoping to see this in GHE as soon as we can

I'm liking the changes. Hopefully the "lines changed" gets updated when you choose a specific commit in the file viewer now too

suralind 16 hours ago||
NGL, I know GH gets a lot of shit about the stability, that's well deserved, but they've been really doing nice UI improvements recently. Hopefully this is a new trend that will also continue with the stability.
greatgib 14 hours ago||
But at the same time, do they still hide/mask/minimize review comments when there are more than 10 in a row?

That is the worst with their UX currently, only challenged by the stupidity of the code diff page that hide the most modified files so you can easily miss them and it is impossible to do a ctrl+f search on the page.

UqWBcuFx6NV4r 14 hours ago||
Amen. I lose comments and get confused as to why merging is blocked on a regular basis.
twhitmore 6 hours ago||
Scrap the entire PR experience, start again from basics. Fire the people responsible.
monster_truck 10 hours ago||
Am I blind or is there no "try overview page" button on the header of this site? Or on any of my PRs
bakies 10 hours ago||
Right off the bat the ux is inconsistent in the examples. The grey bar is optional checks but required approvals
jeffbee 16 hours ago||
These were not really my beef with the PR review page. My beef is that the first round of PR comments becomes unmoored from ground truth after any subsequent commits, making it difficult to see whether comments were addressed, and how.
dawnerd 13 hours ago||
I’ve never once thought I was spending too much time scrolling.
madeofpalk 13 hours ago|
I have. Between all the force pushes showing up in the feed, and various automations adding or removing labels, reviewers, to project boards, etc, the 'feed' tends to get pretty cluttered for me.

I've been using this new PR view for a few weeks now and I much prefer it.

UqWBcuFx6NV4r 14 hours ago|
> The merge box, distilled Nobody, and I mean NOBODY, can legitimately like this Apple-style way or structuring sentences. The only people to remotely get away with it in my mind are Apple themselves (and only becuase they’re grandfathered in), and I get that in the late ‘00s / early ‘10s there was a trend of companies doing this to look more Apple-like, but in 2016 let alone 2026 it’s just camp and cringe. However, LLMs LOVE writing like this whenever they get a slight whiff that they’re being asked to do something in a marketing context. Are GitHub / MS using clearly AI-generated prose just to prove a point or something? Are the internal [dis-]incentives really this bad? Am I going insane? Is this just how all Californians talk?
More comments...